673 tags filtering

[mvandeberg]

PR for #673

Correctly categorizes posts into 5 tags regardless if which tag is the "category" (parent_permlink).

Removes NSFW filtering from the global ranking to defer filtering to UI.

[arhag]

@mvandeberg: I want to make sure you realize that the 0a4e9f7 commit changes the behavior of the main feeds. Before a post that wasn't tagged "spam", "test", or "nsfw" could potentially show up in the various feeds (e.g. hot) even if it had negative net_rshares. Now, such a post will suddenly disappear from the feeds if even a minnow downvotes it and causes net_rshares to even become slightly negative. I believe it will still be visible in the particular tag feeds and the personal feed of followers, but making the post far less visible makes it unlikely for other benevolent users to find the post and upvote it (assuming it is deserved) to make its net_rshares positive again. Perhaps filtering based on net_rshares being below a threshold should be done at the frontend level like with NSFW posts.

Furthermore, now a post with a "spam" or "test" post won't show up in the trending feed even if it has a really high payout. That can allow bad whales to abuse the reward fund with a lower likelihood of getting caught, since the main trending feed will hide their post.

I think changing the && back into || is more appropriate. Then the frontend can have further filtering based on net_rshares and/or the NSFW tag. Or alternatively add the universal tag to all posts and just do all filtering in the frontend.

[mvandeberg]

Good point. The change from or to and was to prevent nsfw content from showing up when it was upvoted. But since we are doing that all on the front end, there is little (if any need for that behavior).

[NateBrune]

I think c.net_rshares >=0 should just be left out of this clause altogether. As it is right now... spam can get a universal tag if it has a positive vote weight. What is the point of checking for spam if nothing is done about it? I am with @arhag though, let's do filtering on the front end.

[mvandeberg]

The point is if spam gets positive votes it needs to show up so it can be down voted. If I wanted to siphon funds I would make spam posts, up vote them, and wait because no one would down vote them.