Skip to content

Commit

Permalink
net/mlx4: fix RSS action with null hash key
Browse files Browse the repository at this point in the history
[ upstream commit 4a750d2 ]

If RSS action contains non zero hash key length and NULL
key buffer pointer the default hash key should be used.
The check for the NULL pointer this was missing in the mlx4
PMD causing crash, for example, in testpmd with command:

flow validate 0 ingress group 0
  pattern eth / ipv4 / end
  actions rss queues 0 end key_len 40 / end

Fixes: ac8d22d ("ethdev: flatten RSS configuration in flow API")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
  • Loading branch information
viacheslavo authored and steevenlee committed May 8, 2021
1 parent fb455a8 commit 00d769c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/mlx4/mlx4_flow.c
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,8 @@ mlx4_flow_prepare(struct mlx4_priv *priv,
rss = action->conf;
/* Default RSS configuration if none is provided. */
if (rss->key_len) {
rss_key = rss->key;
rss_key = rss->key ?
rss->key : mlx4_rss_hash_key_default;
rss_key_len = rss->key_len;
} else {
rss_key = mlx4_rss_hash_key_default;
Expand Down

0 comments on commit 00d769c

Please sign in to comment.