Skip to content

Commit

Permalink
drivers: fix symbol exports when map is omitted
Browse files Browse the repository at this point in the history
[ upstream commit bfc43a0 ]

ld exports any global symbol by default if no version script is passed.
As a consequence, the incriminated change let any public symbol leak
out of the driver shared libraries.

Hide again those symbols by providing a default map file which
unexports any global symbol using a local: * catch-all statement.

The checks are skipped for this default map file as it is intentionnally
an empty map (see commit b67bdda ("devtools: catch empty symbol
maps")) and there is nothing else to check in this map.

This change impacts the exported symbols, hence, bump the version in the
ABI check to the v22.11.1 from the 22.11 LTS branch.

Fixes: 7dde9c8 ("drivers: omit symbol map when unneeded")

Reported-by: Luca Boccassi <luca.boccassi@microsoft.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Aaron Conole <aconole@redhat.com>
  • Loading branch information
david-marchand authored and steevenlee committed Feb 22, 2023
1 parent 9dae7a1 commit 07e68b0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Expand Up @@ -25,7 +25,8 @@ jobs:
MINGW: ${{ matrix.config.cross == 'mingw' }}
MINI: ${{ matrix.config.mini != '' }}
PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
REF_GIT_TAG: none
REF_GIT_REPO: https://dpdk.org/git/dpdk-stable
REF_GIT_TAG: v22.11.1
RISCV64: ${{ matrix.config.cross == 'riscv64' }}
RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}

Expand Down
3 changes: 2 additions & 1 deletion .travis.yml
Expand Up @@ -42,7 +42,8 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
env:
global:
- LIBABIGAIL_VERSION=libabigail-1.8
- REF_GIT_TAG=none
- REF_GIT_REPO=https://dpdk.org/git/dpdk-stable
- REF_GIT_TAG=v22.11.1

jobs:
include:
Expand Down

0 comments on commit 07e68b0

Please sign in to comment.