Skip to content

Commit

Permalink
net/mlx4: fix leak when configured repeatedly
Browse files Browse the repository at this point in the history
[ upstream commit 6f14d4d ]

Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.

For example:
for(...)
do
    rte_eth_dev_configure
    rte_eth_rx_queue_setup
    rte_eth_tx_queue_setup
    rte_eth_dev_start
    rte_eth_dev_stop
done

Fixes: 97d37d2 ("net/mlx4: remove device register remap")

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
  • Loading branch information
wyjwang authored and steevenlee committed Jun 8, 2021
1 parent 6156da1 commit 2471e99
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/mlx4/mlx4.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ mlx4_proc_priv_init(struct rte_eth_dev *dev)
struct mlx4_proc_priv *ppriv;
size_t ppriv_size;

mlx4_proc_priv_uninit(dev);
/*
* UAR register table follows the process private structure. BlueFlame
* registers for Tx queues are stored in the table.
Expand Down

0 comments on commit 2471e99

Please sign in to comment.