Skip to content

Commit

Permalink
net/hns3: fix link status when port is stopped
Browse files Browse the repository at this point in the history
[ upstream commit 6430855 ]

When port is stopped, link down should be reported to user. For HNS3
PF driver, link status comes from link status of hardware. If the port
supports NCSI feature, hardware MAC will not be disabled. At this case,
even if the port is stopped, the link status is still Up. So driver
should set link down when the port is stopped.

Fixes: 59fad0f ("net/hns3: support link update operation")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
  • Loading branch information
LiHuiSong1 authored and steevenlee committed Jun 8, 2021
1 parent 47b2b44 commit 3502d41
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/net/hns3/hns3_ethdev.c
Expand Up @@ -2709,6 +2709,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
struct rte_eth_link new_link;
int ret;

/* When port is stopped, report link down. */
if (eth_dev->data->dev_started == 0) {
new_link.link_autoneg = mac->link_autoneg;
new_link.link_duplex = mac->link_duplex;
new_link.link_speed = ETH_SPEED_NUM_NONE;
new_link.link_status = ETH_LINK_DOWN;
goto out;
}

ret = hns3_update_port_link_info(eth_dev);
if (ret) {
mac->link_status = ETH_LINK_DOWN;
Expand All @@ -2718,6 +2727,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
memset(&new_link, 0, sizeof(new_link));
hns3_setup_linkstatus(eth_dev, &new_link);

out:
return rte_eth_linkstatus_set(eth_dev, &new_link);
}

Expand Down

0 comments on commit 3502d41

Please sign in to comment.