Skip to content

Commit

Permalink
net/bnxt: check PCI config read
Browse files Browse the repository at this point in the history
[ upstream commit 52c3373 ]

Return value where return value of rte_pci_read_config was not checked.
Fix it.

Coverity issue: 349919
Fixes: 9d0cbae ("net/bnxt: support periodic FW health monitoring")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
  • Loading branch information
ajitkhaparde authored and steevenlee committed Jun 8, 2021
1 parent 91d4a17 commit e00127b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/net/bnxt/bnxt_ethdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -4138,13 +4138,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index)
struct bnxt_error_recovery_info *info = bp->recovery_info;
uint32_t reg = info->status_regs[index];
uint32_t type, offset, val = 0;
int ret = 0;

type = BNXT_FW_STATUS_REG_TYPE(reg);
offset = BNXT_FW_STATUS_REG_OFF(reg);

switch (type) {
case BNXT_FW_STATUS_REG_TYPE_CFG:
rte_pci_read_config(bp->pdev, &val, sizeof(val), offset);
ret = rte_pci_read_config(bp->pdev, &val, sizeof(val), offset);
if (ret < 0)
PMD_DRV_LOG(ERR, "Failed to read PCI offset %#x",
offset);
break;
case BNXT_FW_STATUS_REG_TYPE_GRC:
offset = info->mapped_status_regs[index];
Expand Down

0 comments on commit e00127b

Please sign in to comment.