Enable IBM TSS2 test via package for Bionic #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make swtpm_setup.sh work on Travis on Bionic we need to explicitly set TCSD_TCP_DEVICE_HOSTAME=127.0.0.1 since lookup of localhost (with the API the tcsd is using) does not work. It doesn't negatively affect any other use case, so no problem setting it. Also replace localhost in the bash tcp device path with 127.0.0.1. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
To make the test cases work on Travis on Bionic replace all occurrences of localhost with 127.0.0.1. The only affected client tools seem to be those related to the TPM 1.2 and the IBM TSS2. For some reason the API used there cannot resolve localhost to 127.0.0.1. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
The IBM TSS2 is available starting with Bionic. Use it there to extend the test coverage of the code. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Modify the test_tpm2_save_load_state_3 to create 2 orderly NVRAM indices in the first two locations. Those indices will be cleared by a reset of the TPM and therefore cannot be read once the TPM 2 restarts after the reset. This also provides better test coverage. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Pull Request Test Coverage Report for Build 1967
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable another IBM TSS2 related test by installing the tss2 package on Bionic. Unfortunately it wasn't as easy as moving certain test runs to Bionic but there were problems with Bionic on Travis that I could not recreate on a normal Bionic installation. The issues were related to resolving localhost to 127.0.0.1 by some TSS 1.2 and TSS 2 tools that worked fine on Xenial (on Travis) but errored on Bionic. So some adjustments had to be made to some tools and test cases to not use localhost but 127.0.0.1.