build-sys: add configure option to disable installation of Python module #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2590
💛 - Coveralls |
stefanberger
reviewed
Sep 3, 2020
|
I would merge this patch in after #319. I suppose the order on the master branch doesn't matter to you. Maybe that you would like this patch applied to a stable-0.4 branch? |
Distributions often have their own guidelines regarding installation of Python modules (e.g. Arch Linux mandates using --optimize=1 for setup.py install, which the Makefile in this project does not do). Add an option "--disable-python-installation" (disabled by default) to allow skipping the Python installation process entirely so that distributions can take care of this process manually in their preferred way. Signed-off-by: Jonas Witschel <diabonas@archlinux.org>
diabonas
force-pushed
the
skip-python-installation
branch
from
596af0f
to
03de14d
Compare
Sure, I rebased the PR onto the current master.
That would make things easier for me in case there is another 0.4.x release, thanks! |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributions often have their own guidelines regarding installation of Python modules (e.g. Arch Linux mandates using
--optimize=1forsetup.py install, which the Makefile in this project does not do). Add an option--disable-python-installation(disabled by default) to allow skipping the Python installation process entirely so that distributions can take care of this process manually in their preferred way.