Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for this great project #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scriptease
Copy link

Hello thanks for you great project.

When trying it out if found some small issues and fixed them:
1.) The Readme suggests new Configuration().disabledByDefault(), however due to the default visibility it's not accessible from outside the package.
2.) The jersey resources I use are themselves enhanced by guice and the annotations didn't work when I used the disabledByDefault()

I would like to contribute the changes back.

Kind regards Florian

…ake check enabled work with classes that are 'enhanced' by guice
@scriptease
Copy link
Author

It seems like the CI stopped working for Oracle Java 8
Installing oraclejdk8 176$ export JAVA_HOME=~/oraclejdk8 177$ export PATH="$JAVA_HOME/bin:$PATH" 178$ ~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL" 179Ignoring license option: BCL -- using GPLv2+CE by default 180install-jdk.sh 2020-06-02 181Expected feature release number in range of 9 to 18, but got: 8 182The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .

@stefanbirkner
Copy link
Owner

Release 1.0.3 contains the change that makes new Configuration().disabledByDefault() public.

@stefanbirkner
Copy link
Owner

@scriptease Do you think you can provide a test case that shows the Guice enhancement for the Jersey resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants