Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven pick a snapshot dependency of commons-io #32

Closed
laurentleseigneur opened this issue Sep 7, 2015 · 4 comments
Closed

maven pick a snapshot dependency of commons-io #32

laurentleseigneur opened this issue Sep 7, 2015 · 4 comments
Milestone

Comments

@laurentleseigneur
Copy link

when organization uses system-rules for testing, specific maven settings agains maven repo & mirrors makes it hard to resolve commons-io to 2.5-SNAPSHOT as suggested in 1.12.1 in a smart way, specially on CI build on docker

i suggests to fix version instead of allowing a range.

#30

@akhleung
Copy link

Having the same issue, I think -- my builds are failing because there's a dependency on commons-io:jar:2.6-SNAPSHOT.

@stefanbirkner
Copy link
Owner

I think that version ranges are the best way for defining the versions of a library's dependencies. If you want to have a fixed version of commons-io for your test then you can add

<dependency>
  <groupId>commons-io</groupId>
  <artifactId>commons-io</artifactId>
  <version>[2.4]</version>
  <scope>test</scope>
</dependency>

to your pom.xml.

@laurentleseigneur
Copy link
Author

Thanks for your response Stefan.

I already applied this to make version 1.12.1 work as expected, and the initial goal of my PR was to prevent users having the same issue.

If you want to stay with this ranged-version pattern, which i understand, just close my PR, but may be you could add a guidance paragraph in the README.md to avoid this confusing maven dependency resolutions.

@stefanbirkner stefanbirkner added this to the 1.15.0 milestone Dec 3, 2015
@stefanbirkner
Copy link
Owner

System Rules 1.15.0 does not depend on commons-io anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants