-
-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: mitigating script injection attacks by passing issue body as en…
…v var (#42) BREAKING CHANGE: Add `issue-body` argument which is required from v3 onwards To mitigate script injection attacks, github-issue-parser v3 will require workflow authors to pass the issue body as an argument. By doing so you will follow GitHub's [Good practices for mitigating script injection attacks ](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#good-practices-for-mitigating-script-injection-attacks) ```yml - uses: stefanbuck/github-issue-parser@v3 id: issue-parser with: issue-body: ${{ github.event.issue.body }} # required template-path: .github/ISSUE_TEMPLATE/bug-report.yml # optional but recommended ```
- Loading branch information
1 parent
1d341cb
commit 0b27d4a
Showing
16 changed files
with
3,731 additions
and
167 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"contact": "me@me.com", | ||
"what_happened": "A bug happened!", | ||
"version": "1.0.0", | ||
"browsers": "Chrome, Safari", | ||
"anything_else": ["Never give up"], | ||
"second_anything_else": ["Hot Dog is a Sandwich", "Another item"], | ||
"checkbox_without_an_id": [] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
body: | ||
- type: input | ||
id: contact | ||
attributes: | ||
label: Your contact details | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: what_happened | ||
attributes: | ||
label: What happened? | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: version | ||
attributes: | ||
label: Version | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: browsers | ||
attributes: | ||
label: What browsers are you seeing the problem on? | ||
validations: | ||
required: true | ||
|
||
- type: checkboxes | ||
id: anything_else | ||
attributes: | ||
label: What else? | ||
options: | ||
- label: Never give up | ||
- label: Hot Dog is a Sandwich | ||
|
||
- type: checkboxes | ||
id: second_anything_else | ||
attributes: | ||
label: And with that? | ||
options: | ||
- label: Never give up | ||
- label: Hot Dog is a Sandwich | ||
- label: Another item | ||
|
||
- type: checkboxes | ||
attributes: | ||
label: Checkbox without an id? | ||
options: | ||
- label: IDs are great | ||
- label: IDs are bad |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
### Your contact details | ||
|
||
me@me.com | ||
|
||
### What happened? | ||
|
||
A bug happened! | ||
|
||
### Version | ||
|
||
1.0.0 | ||
|
||
### What browsers are you seeing the problem on? | ||
|
||
Chrome, Safari | ||
|
||
### What else? | ||
|
||
- [x] Never give up | ||
- [ ] Hot Dog is a Sandwich | ||
|
||
### And with that? | ||
|
||
- [] Never give up | ||
- [X] Hot Dog is a Sandwich | ||
- [x] Another item | ||
|
||
### Checkbox without an id? | ||
|
||
- [ ] IDs are great | ||
- [ ] IDs are bad |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
const { resolve } = require("path"); | ||
const { readFileSync } = require("fs"); | ||
|
||
const issueBodyPath = resolve(__dirname, "issue-body.md"); | ||
|
||
module.exports = readFileSync(issueBodyPath, "utf-8"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,4 @@ | ||
{ | ||
"contact": "me@me.com", | ||
"what_happened": "A bug happened!", | ||
"version": "1.0.0", | ||
"browsers": "Chrome, Safari", | ||
"anything_else": ["Never give up"], | ||
"second_anything_else": ["Hot Dog is a Sandwich", "Another item"], | ||
"checkbox_without_an_id": [] | ||
"favorite_dish": "Pizza", | ||
"favorite_color": ["Red", "Blue"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,57 +1,16 @@ | ||
name: Bug | ||
description: Something is broken | ||
|
||
title: "Order Pizza" | ||
|
||
body: | ||
- type: input | ||
id: contact | ||
attributes: | ||
label: Your contact details | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: what_happened | ||
id: favorite_dish | ||
attributes: | ||
label: What happened? | ||
label: What's your favorite dish? | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: version | ||
attributes: | ||
label: Version | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: browsers | ||
attributes: | ||
label: What browsers are you seeing the problem on? | ||
validations: | ||
required: true | ||
|
||
- type: checkboxes | ||
id: anything_else | ||
attributes: | ||
label: What else? | ||
options: | ||
- label: Never give up | ||
- label: Hot Dog is a Sandwich | ||
|
||
- type: checkboxes | ||
id: second_anything_else | ||
attributes: | ||
label: And with that? | ||
options: | ||
- label: Never give up | ||
- label: Hot Dog is a Sandwich | ||
- label: Another item | ||
|
||
- type: checkboxes | ||
id: favorite_color | ||
attributes: | ||
label: Checkbox without an id? | ||
label: What's your preferred color? | ||
options: | ||
- label: IDs are great | ||
- label: IDs are bad | ||
- label: Red | ||
- label: Green | ||
- label: Blue |
Oops, something went wrong.