Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new language: basque #38

Closed
erral opened this issue Sep 24, 2020 · 16 comments
Closed

Add new language: basque #38

erral opened this issue Sep 24, 2020 · 16 comments

Comments

@erral
Copy link

erral commented Sep 24, 2020

Hi:

This project has been very useful for us to get the translations of the country names for a project.

Can you please add basque (eu) translations? The wikipedia page is up to date with official basque names, and if someone is missing I will update it right away:

@stefangabos
Copy link
Owner

Just found out very interesting stuff about the basque language!

Here's the stuff that's not ok

Curaçao, cw, 531, cuw
Saint Barthélemy, bl, 652, blm
Saint Martin (French part), mf, 663, maf
Sint Maarten (Dutch part), sx, 534, sxm
Svalbard and Jan Mayen, sj, 744, sjm

@erral
Copy link
Author

erral commented Sep 24, 2020

I added those to the table. The wikipedia page for Svalbard and Jan Mayen is missing, but I will create it later today or tomorrow. I hope that it's not an obstacle to run your script.

@stefangabos
Copy link
Owner

stefangabos commented Sep 24, 2020

No, those pages aren't required - just the entries on the ISO 3166 page; you can create the entries without having to make them as links

@stefangabos
Copy link
Owner

there's an error on the page - look for Txantiloi:Herrialde info Svalbard eta Jan Mayen

@erral
Copy link
Author

erral commented Sep 24, 2020

Yep, we have just fixed the error and now the table should be completed.

@stefangabos
Copy link
Owner

Almost there.
Looking in the history, i think you accidentally removed [Saint Kitts and Nevis, kn, 659, kna].
And still missing is [Bonaire, Sint Eustatius and Saba, bq, 535, bes] - I don't know why my script didn't show this to me the first time
Thanks!

@erral
Copy link
Author

erral commented Sep 24, 2020

I restored Saint Kittis and added Bonaire :)

@stefangabos
Copy link
Owner

stefangabos commented Sep 24, 2020

Done!
Note that Belgika and Belize are present twice, once at the bottom of the page (on Wikipedia, I mean)
Thanks a lot for your help!

@erral
Copy link
Author

erral commented Sep 25, 2020

I wonder why we had that on Wikipedia....

I fixed that, anyway. Thanks!

@erral
Copy link
Author

erral commented Sep 25, 2020

Just one more thing, I have seen that you have added basque language with the "es-pv" code. I think that that's the code for the Basque region in Spain and not the code for the language, which is "eu". Can you check it? See: https://en.wikipedia.org/wiki/ISO_3166-2:ES

@stefangabos
Copy link
Owner

stefangabos commented Sep 25, 2020 via email

@erral
Copy link
Author

erral commented Sep 25, 2020

Yes but "basque" is a language and not a subdivision, right? It should be a ISO-639-1 code shouldn't it?

@stefangabos
Copy link
Owner

stefangabos commented Sep 25, 2020 via email

@stefangabos
Copy link
Owner

Should be good now

@erral
Copy link
Author

erral commented Sep 25, 2020

Indeed. Thanks!!!

@erral erral closed this as completed Sep 25, 2020
@stefangabos
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants