add directory check for node_modules scan

stefanjudis · Nov 21, 2015 · c6c8d2d · c6c8d2d
1 parent a9f0ce0
commit c6c8d2d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -39,8 +39,16 @@ function readDirectory( projectPath, credits, seen ) {
   }
 
   deps.forEach( function( name ) {
-    if ( name !== '.bin' ) {
-      var packageJson = require( path.join( depPath, name, 'package.json' ) );
+    var directoryPath = path.join( depPath, name );
+
+    if (
+      name !== '.bin' &&
+      (
+        fs.lstatSync( directoryPath ).isDirectory() ||
+        fs.lstatSync( directoryPath ).isSymbolicLink()
+      )
+    ) {
+      var packageJson = require( path.join( directoryPath, 'package.json' ) );
       var author      = packageUtil.getAuthor( packageJson );
       var maintainers = packageUtil.getMaintainers( packageJson );
 
@@ -54,7 +62,7 @@ function readDirectory( projectPath, credits, seen ) {
         } );
       }
 
-      readDirectory( fs.realpathSync( path.join( depPath, name ) ), credits, seen );
+      readDirectory( fs.realpathSync( directoryPath ), credits, seen );
     }
   } );
 

diff --git a/index.spec.js b/index.spec.js
@@ -14,18 +14,15 @@ test( 'credits - folder exists', t => {
       'utf8'
     );
 
-
     fs.mkdirSync( `${path}/node_modules/bar` );
     fs.writeFileSync(
       `${path}/node_modules/bar/package.json`,
       JSON.stringify( { author : 'Alice Bobson' } ),
       'utf8'
     );
 
-
     fs.mkdirSync( `${path}/node_modules/bar/node_modules` );
     fs.mkdirSync( `${path}/node_modules/bar/node_modules/boom` );
-
     fs.writeFileSync(
       `${path}/node_modules/bar/node_modules/boom/package.json`,
       JSON.stringify( { author : { name : 'Alice Bobson' } } ),
@@ -50,7 +47,6 @@ test( 'credits - folder exists', t => {
 
     fs.mkdirSync( `${path}/node_modules/baz/node_modules` );
     fs.mkdirSync( `${path}/node_modules/baz/node_modules/boing` );
-
     fs.writeFileSync(
       `${path}/node_modules/baz/node_modules/boing/package.json`,
       JSON.stringify( { author : 'Bob Calsow <bob@calsow.io>' } ),