Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor files #92

Merged
merged 10 commits into from
Oct 10, 2016
Merged

Refactor files #92

merged 10 commits into from
Oct 10, 2016

Conversation

Hypercubed
Copy link
Collaborator

This is a refactor of the source files but no functional changes.

  1. All tests are based in static fixtures rather than generated.
  2. Tests and fixtures are located in the test directory.
  3. test directory is not included in published package.

@Hypercubed
Copy link
Collaborator Author

Since this is a big change I'd like to get an LGTM from @stefanjudis .

@coveralls
Copy link

coveralls commented Oct 9, 2016

Coverage Status

Coverage decreased (-2.6%) to 95.946% when pulling 55b8193 on Hypercubed:refactor into 439f305 on stefanjudis:master.

@Hypercubed
Copy link
Collaborator Author

Sorry about the noise on this... had some trouble getting the CI to pass.

@coveralls
Copy link

coveralls commented Oct 9, 2016

Coverage Status

Coverage decreased (-2.6%) to 95.946% when pulling 918d627 on Hypercubed:refactor into 439f305 on stefanjudis:master.

@Hypercubed
Copy link
Collaborator Author

I think this is ready to merge. After this I think I'm going to replace the manual searching with globbing.

@stefanjudis
Copy link
Owner

stefanjudis commented Oct 10, 2016

After this I think I'm going to replace the manual searching with globbing

👍

Tests and fixtures are located in the test directory.

Looks solid to me! 🎉

Why did the test coverage decrease?

@Hypercubed
Copy link
Collaborator Author

Not sure why coverage decreased. I'll look into it.

@Hypercubed Hypercubed merged commit 5b8a253 into stefanjudis:master Oct 10, 2016
@Hypercubed Hypercubed deleted the refactor branch October 10, 2016 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants