Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in Rails 5.1 about using dirty tracking #359

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
3 participants
@westonganger
Copy link

commented Aug 30, 2017

No description provided.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.02%) to 97.527% when pulling 5baf72a on westonganger:patch-1 into 3b042ad on stefankroes:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.02%) to 97.527% when pulling 5baf72a on westonganger:patch-1 into 3b042ad on stefankroes:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.02%) to 97.527% when pulling 3b76ca0 on westonganger:patch-1 into 3b042ad on stefankroes:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.02%) to 97.527% when pulling 3b76ca0 on westonganger:patch-1 into 3b042ad on stefankroes:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.02%) to 97.527% when pulling effdd4d on westonganger:patch-1 into 3b042ad on stefankroes:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.03%) to 97.541% when pulling 23f7f0d on westonganger:patch-1 into 3b042ad on stefankroes:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.03%) to 97.541% when pulling 25fbdeb on westonganger:patch-1 into 3b042ad on stefankroes:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.03%) to 97.541% when pulling 25fbdeb on westonganger:patch-1 into 3b042ad on stefankroes:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.03%) to 97.541% when pulling 35c266a on westonganger:patch-1 into 3b042ad on stefankroes:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.03%) to 97.541% when pulling 35c266a on westonganger:patch-1 into 3b042ad on stefankroes:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2017

Coverage Status

Coverage increased (+0.02%) to 97.527% when pulling 9214fbd on westonganger:patch-1 into 3b042ad on stefankroes:master.

@westonganger westonganger deleted the westonganger:patch-1 branch Aug 30, 2017

@macfanatic

This comment has been minimized.

Copy link

commented Nov 14, 2017

Any hints as to why this wasn't merged @westonganger?

@westonganger

This comment has been minimized.

Copy link
Author

commented Nov 14, 2017

I remember creating this PR then sometime after thinking that possibly this library was not the cause. But honestly I just sort of learned to live with the Rails deprecations which however are extremely annoying.

If someone else can verify this code, this PR could be looked into again.

@macfanatic

This comment has been minimized.

Copy link

commented Nov 14, 2017

Thanks for the info. I was able to identify this as the culprit of a ton of deprecation warnings in our codebase (noticed in rspec test runs) with upgrade to Rails 5.1

I had implemented something similar but didn't have any luck keeping the tests passing locally so tabling for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.