Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordered_by_ancestry for oracle-db #535

Closed

Conversation

lual
Copy link

@lual lual commented Apr 16, 2021

An empty string is treated as NULL in Oracle.
COALESCE(NULL,'') is treated as NULL.
So Ordering ascending, deliver NULL-Values at the rear.

…NULL in Oracle. Ordering ascending, deliver NULL-Values at the rear.)
@coveralls
Copy link

coveralls commented Apr 16, 2021

Coverage Status

Coverage decreased (-0.2%) to 97.837% when pulling 0483b1b on rtiss:ordered_by_ancestry_for_oracle into 2ff497e on stefankroes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 97.831% when pulling 0483b1b on rtiss:ordered_by_ancestry_for_oracle into 2ff497e on stefankroes:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 97.831% when pulling 0483b1b on rtiss:ordered_by_ancestry_for_oracle into 2ff497e on stefankroes:master.

@kbrock kbrock mentioned this pull request May 14, 2021
@kbrock
Copy link
Collaborator

kbrock commented May 14, 2021

@lual could you run with the patch from #541 and verify it meets your needs?

I'm pretty sure the postgresql solution will meet your needs. Wrapping in the ascend allows reverse ordering not to blow up.

@kbrock kbrock closed this May 14, 2021
@kbrock
Copy link
Collaborator

kbrock commented May 14, 2021

Better yet, would you make the changes I made over there and put them into your pr? that way you could get credit

@kbrock kbrock reopened this May 14, 2021
@kbrock
Copy link
Collaborator

kbrock commented May 17, 2021

I'll give you a few days, otherwise I'll just merge that other PR and hopefully that will meet your needs

@kbrock
Copy link
Collaborator

kbrock commented May 26, 2021

leaving this one open until I share a good monkey patch to you.
the suggested code here would not pass the test suite, so I prefer/merged the other version
specifically when people reverse the order of the ancestry column

@kbrock
Copy link
Collaborator

kbrock commented Jun 23, 2021

monkey patch in #535 should hold you over until the next version of rails is released

@kbrock kbrock closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants