Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the valid check to not only run on the entire object #542

Merged
merged 1 commit into from
Jun 3, 2021
Merged

change the valid check to not only run on the entire object #542

merged 1 commit into from
Jun 3, 2021

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented May 20, 2021

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.068% when pulling 824e8e6 on d-m-u:fix_sanity into 0a1337e on stefankroes:master.

@d-m-u d-m-u mentioned this pull request May 20, 2021
Merged
@kbrock
Copy link
Collaborator

kbrock commented May 26, 2021

kicking

@kbrock kbrock closed this May 26, 2021
@kbrock kbrock reopened this May 26, 2021
@kbrock
Copy link
Collaborator

kbrock commented May 26, 2021

maybe you can add a test around updating a model with invalid data in it or something?
not sure the best way to test this use case

@kbrock kbrock merged commit 716b2d2 into stefankroes:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-m-u @coveralls @kbrock