introduce COLLATE_SYMBOLS=false to talor test environments #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
kbrock
force-pushed
the
collate
branch
2 times, most recently
from
9d5c4c1
to
00920e6
Compare
Most database ship with locales built in so they are consistent across installations. Postgres does not ship with locales so it uses the ones in the operating system. In the locales there is collation, which basically defines how to sort. We will mostly notice this in the following 2 ways: - case sensitive sorting - include symbols in the sorting case sensitive: "B", "E", "c", "d" non-case Insensitive: "B", "c", "d", "E" include symbols: "Sams Golf Shop", "Sam's Cantina" ignore symbols: "Sam's Cantina", "Sams Golf Shop" In our domain, the ignoring symbols causes some issues: include symbols: "1/2/3", "1/2/5", "1/4", "12/4" ignore symbols: "1/2/3", "12/4", "1/2/5", "1/4" (think alphabetic sort: "123", "125", "14", 124") If you are ordering them to put into a tree, then this gets confusing and can result in children coming back out of order. This is tricky for arrange. An option was introduced for the case when symbols are not considered. It essentially 'join' the strings together to simulate ignoring the symbols. Also do remember, that this is sorting alphabetically rather than numerically. So 14 > 123.
|
kicking (using a newer mysql - hope this fixes ssl connectivity errors and gets this green) |
|
this is unreleated to mysql. merging to fix pg issues so hopefully we're only left with mysql issues (and can get this master green) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most database ship with locales built in so they are consistent across installations.
Postgres does not ship with locales so it uses the ones in the operating system.
In the locales there is collation, which basically defines how to sort. We will mostly
notice this in the following 2 ways:
case sensitive: "B", "E", "c", "d"
non-case Insensitive: "B", "c", "d", "E"
include symbols: "Sams Golf Shop", "Sam's Cantina"
ignore symbols: "Sam's Cantina", "Sams Golf Shop"
In our domain, the ignoring symbols causes some issues:
include symbols: "1/2/3", "1/2/5", "1/4", "12/4"
ignore symbols: "1/2/3", "12/4", "1/2/5", "1/4" (think alphabetic sort: "123", "125", "14", 124")
If you are ordering them to put into a tree, then this gets confusing and
can result in children coming back out of order. This is tricky for arrange.
An option was introduced for the case when symbols are not considered. It essentially
'join' the strings together to simulate ignoring the symbols.
Also do remember, that this is sorting alphabetically rather than numerically. So 14 > 123.