Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default ancestry format and primary key format #612

Merged
merged 1 commit into from Mar 3, 2023

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented Mar 2, 2023

These tend to be the same across a whole database.

The primary key format is used for databases with uuids for the primary key The ancestry format makes it easy for a new user to get up and running using a different ancestry encoding format

These tend to be the same across a whole database.

The primary key format is used for databases with uuids for the primary key
The ancestry format makes it easy for a new user to get up and running
using a different ancestry encoding format
@kbrock
Copy link
Collaborator Author

kbrock commented Mar 2, 2023

@kshnurov do you know how to use mattr_accessor here?

I feel this is probably the easiest way to get users up and running using the new materialized path2.

@kbrock
Copy link
Collaborator Author

kbrock commented Mar 3, 2023

if you have an answer, we can circle back later. I want to get this merged, so I can use it in documenting ancestry collation and get us closer to a gem release

@kbrock kbrock merged commit 53f1914 into stefankroes:master Mar 3, 2023
@kbrock kbrock deleted the default_ancestry_format branch March 3, 2023 02:41
kbrock added a commit to kbrock/ancestry that referenced this pull request Mar 3, 2023
* Fix: descendants ancestry is now updated in after_update callbacks stefankroes#589
* Document updated grammar stefankroes#594
* Documented `update_strategy` stefankroes#588
* Fix: fixed has_parent? when non-default primary id stefankroes#585
* Documented column collation and testing stefankroes#601 stefankroes#607
* Added initializer with default_ancestry_format stefankroes#612
* ruby 3.2 support stefankroes#596
kbrock added a commit to kbrock/ancestry that referenced this pull request Mar 3, 2023
* Fix: materialized_path2 strategy stefankroes#597
* Fix: descendants ancestry is now updated in after_update callbacks stefankroes#589
* Document updated grammar stefankroes#594
* Documented `update_strategy` stefankroes#588
* Fix: fixed has_parent? when non-default primary id stefankroes#585
* Documented column collation and testing stefankroes#601 stefankroes#607
* Added initializer with default_ancestry_format stefankroes#612
* ruby 3.2 support stefankroes#596
@kshnurov
Copy link
Contributor

kshnurov commented Mar 3, 2023

You're instantly merging things left and right without even thinking and reviewing. What the hell is going on?

@kbrock
Copy link
Collaborator Author

kbrock commented Mar 4, 2023

I wanted to simplify our readme and this made it easier.
Yes, I did find a bug after the fact. I am putting in a PR to fix.

kbrock added a commit to kbrock/ancestry that referenced this pull request Mar 4, 2023
* Fix: materialized_path2 strategy stefankroes#597
* Fix: descendants ancestry is now updated in after_update callbacks stefankroes#589
* Document updated grammar stefankroes#594
* Documented `update_strategy` stefankroes#588
* Fix: fixed has_parent? when non-default primary id stefankroes#585
* Documented column collation and testing stefankroes#601 stefankroes#607
* Added initializer with default_ancestry_format stefankroes#612
* ruby 3.2 support stefankroes#596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants