Support overriding apply_orphan_strategy #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply_orphan_strategy was removed in 1a25355 Many gems override this method to apply a custom orphan strategy This adds support back and adds a test around the behavior If a developer uses super in this method, that will break You will need to directly call the desired apply_orphan_strategy_* instead
kbrock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply_orphan_strategy was removed in #617
Many gems override this method to apply a custom orphan strategy
This adds support back and adds a test around the behavior
breaking change:
If a developer calls
super()fromapply_orphan_strategy, it will no longer work.Fix:
directly call the desired strategy
apply_orphan_strategy_*instead