Alt ancestry column suite #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things changed a bit here. In tests, we are now always passing ancestry_column into has_ancestry (in with_model) This value is from an env variable or defaulting to ancestry So when code calls has_ancestry, we're not sure the name of the field in the database so we need to be more careful. Mostly noticeable in the tests that manually call has_ancestry And the test of the default ancestry column name (which assumed has_ancestry was being called without values)
we are running all tests with an alt ancestry, so these are no longer necessary
kbrock
force-pushed
the
alt_ancestry_column_suite
branch
from
f6fef3a
to
fd0b86d
Compare
|
@kbrock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup from #656
Running test suite with an alternate ancestry column to ensure all tests work with an alt ancestry column.
@mitsuru These tests should be more complete for you.