Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken JSONP. #322

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

svbatalov
Copy link
Contributor

Fixes #321

@svbatalov svbatalov mentioned this pull request Mar 30, 2023
@E-gy
Copy link

E-gy commented May 5, 2023

Just further noting that this also fixes the exactly similar issue with Ajax mode (since _retrieveData is either _recordsFromJsonp or _recordsFromAjax, both with same signature).

That's issue #318.

@E-gy
Copy link

E-gy commented May 5, 2023

It seems to have broken in 3.0.9, as arguments are correct in 3.0.5 - which thus works as a temporary workaround.
image

@jt196 jt196 mentioned this pull request Jun 2, 2023
@stefanocudini
Copy link
Owner

It seems to have broken in 3.0.9, as arguments are correct in 3.0.5 - which thus works as a temporary workaround.

I'll check and merge soon, tnks!

@stefanocudini stefanocudini merged commit 6615574 into stefanocudini:master Aug 8, 2023
@stefanocudini
Copy link
Owner

@svbatalov this merge cause this problem:
image

@mikelcp
Copy link

mikelcp commented Jan 12, 2024

@stefanocudini any updates on my pr?
It should resolve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONP broken
4 participants