Skip to content

Commit

Permalink
Merge pull request #313 from stefanoslig/migrate-v18
Browse files Browse the repository at this point in the history
chore: migrate to angular 18
  • Loading branch information
stefanoslig committed May 30, 2024
2 parents 579eb25 + c11dfe8 commit bc2f02a
Show file tree
Hide file tree
Showing 4 changed files with 3,916 additions and 2,517 deletions.
6 changes: 2 additions & 4 deletions libs/home/src/lib/home.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ export class HomeComponent {
$listConfig = this.articlesListStore.listConfig;
tags$ = this.homeStore.tags$;

constructor() {
this.articlesListStore.loadArticles(this.$listConfig);
}

readonly loadArticlesOnLogin = effect(() => {
const isLoggedIn = this.authStore.loggedIn();
untracked(() => this.getArticles(isLoggedIn));
Expand All @@ -36,6 +32,7 @@ export class HomeComponent {
setListTo(type: ListType = 'ALL') {
const config = { ...articlesListInitialState.listConfig, type };
this.articlesListStore.setListConfig(config);
this.articlesListStore.loadArticles(this.$listConfig());
}

getArticles(isLoggedIn: boolean) {
Expand All @@ -54,5 +51,6 @@ export class HomeComponent {
tag,
},
});
this.articlesListStore.loadArticles(this.$listConfig());
}
}
50 changes: 15 additions & 35 deletions migrations.json
Original file line number Diff line number Diff line change
@@ -1,49 +1,29 @@
{
"migrations": [
{
"version": "18.1.0-beta.3",
"description": "Moves affected.defaultBase to defaultBase in `nx.json`",
"implementation": "./src/migrations/update-17-2-0/move-default-base",
"package": "nx",
"name": "move-default-base-to-nx-json-root"
},
{
"cli": "nx",
"version": "18.1.0-beta.1",
"version": "19.1.0-beta.2",
"requires": {
"@angular/core": ">=17.2.0"
"@angular/core": ">=18.0.0"
},
"description": "Update the @angular/cli package version to ~17.2.0.",
"factory": "./src/migrations/update-18-1-0/update-angular-cli",
"description": "Update the @angular/cli package version to ~18.0.0.",
"factory": "./src/migrations/update-19-1-0/update-angular-cli",
"package": "@nx/angular",
"name": "update-angular-cli-version-17-2-0"
"name": "update-angular-cli-version-18-0-0"
},
{
"cli": "nx",
"version": "18.1.1-beta.0",
"description": "Ensure targetDefaults inputs for task hashing when '@nx/angular:webpack-browser' is used are correct for Module Federation.",
"factory": "./src/migrations/update-18-1-1/fix-target-defaults-inputs",
"package": "@nx/angular",
"name": "fix-target-defaults-for-webpack-browser"
"version": "18.0.0",
"description": "Updates two-way bindings that have an invalid expression to use the longform expression instead.",
"factory": "./migrations/invalid-two-way-bindings/bundle",
"package": "@angular/core",
"name": "invalid-two-way-bindings"
},
{
"cli": "nx",
"version": "18.2.0-beta.0",
"requires": {
"@angular/core": ">=17.3.0"
},
"description": "Update the @angular/cli package version to ~17.3.0.",
"factory": "./src/migrations/update-18-2-0/update-angular-cli",
"package": "@nx/angular",
"name": "update-angular-cli-version-17-3-0"
},
{
"cli": "nx",
"version": "18.1.0-beta.3",
"description": "Update to Cypress ^13.6.6 if the workspace is using Cypress v13 to ensure workspaces don't use v13.6.5 which has an issue when verifying Cypress.",
"implementation": "./src/migrations/update-18-1-0/update-cypress-version-13-6-6",
"package": "@nx/cypress",
"name": "update-cypress-version-13-6-6"
"version": "18.0.0",
"description": "Replace deprecated HTTP related modules with provider functions",
"factory": "./migrations/http-providers/bundle",
"package": "@angular/core",
"name": "migration-http-providers"
}
]
}
Loading

0 comments on commit bc2f02a

Please sign in to comment.