Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding icamerasrc-git-fix, removed ivsc-driver, fixed v4l2loopback typo #22

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Adding icamerasrc-git-fix, removed ivsc-driver, fixed v4l2loopback typo #22

merged 7 commits into from
Jun 12, 2023

Conversation

striczkof
Copy link
Contributor

@striczkof striczkof commented Jun 11, 2023

Fixes #18 plus the dkms crying about same files when installing ivsc driver. Turns out, it's installed already through ipu6-dkms. Also renamed the v4l2loopback folder to reflect the package name and added a reminder to reboot (got me lol) because why not?

installing and uninstalling works smoothly on my Dell XPS 13 Plus 9320 running Arch Linux kernel 6.3.7-arch1-1, with KDE Plasma on Wayland. Gotta try in a truly fresh install within 3 days but should work flawless.

Working for Firefox, Discord, and OBS with workaround flag. Just crashes Kamoso when I select the virtual camera for some reason.

intel-ivsc-driver-dkms-git is no longer needed and even conflicts with
the intel-ipu6-dkms-git on 'dkms install' due to them being built
together into a single package. Also updated the PKGBUILD of ipu6-dkms
to signify this, plus making it depend on ivsc-firmware.
Added the fixed PKGBUILD to build the earlier icamerasrc. Pointed out by
@sigboe at: #18 (comment)
Fixed a (possible) typo in the script and folder name to reflect the
package name in the PKGBUILD.
@sigboe
Copy link
Contributor

sigboe commented Jun 11, 2023

LGTM 👍

I was planning on making a merge request for this this weekend, but I forgot about it, this also does more cleanup, and housework than what I had ready.

Great job! This restores this repo's main purpose, to be a user friendly way to get the camera working!

Only thing missing now is to go over and update the readme file, to reflect newer kernels!

I hope @stefanpartheym will merge this soon!

To make sure both don't get installed together ig
@striczkof
Copy link
Contributor Author

striczkof commented Jun 12, 2023

Thanks, I was legit crying for 5 hours trying to get my webcam to work until I found your answer and tried removing ivsc-driver because it's conflicting with ipu6-dkms.

@stefanpartheym
Copy link
Owner

Guys, huge thanks for the contributions. It really makes things easy again.
I'll merge this one in a bit.

Best regards
Stefan

@stefanpartheym stefanpartheym merged commit 2259c39 into stefanpartheym:main Jun 12, 2023
@stefanpartheym
Copy link
Owner

Hi @striczkof,
sorry I kinda merged your pull request too early I guess.
Turns out, installation fails due to:
(in German)

==> FEHLER: 70-ipu6-psys.rules wurde nicht im build Verzeichnis gefunden und ist keine URL.

(in English)

==> ERROR: 70-ipu6-psys.rules was not found in build directory and is not an URL.

After adding the file as icamerasrc-git/70-ipu6-psys.rules:

# This rule makes the Intel IPU6 sensor accessible to members of group 'video',
# allowing icamerasrc to be used as an unprivileged user.
SUBSYSTEM=="intel-ipu6-psys",GROUP="video",MODE="0660"

Installation works fine.
Can you confirm? If yes, I'll just commit the file accordingly.

@elhossary
Copy link

elhossary commented Jun 12, 2023

Hi,
Let me hop in here.
I added icamerasrc-git/70-ipu6-psys.rules file manually, and it WORKS for the first time in my Alder lake X1 carbon
Thank you all

@striczkof
Copy link
Contributor Author

striczkof commented Jun 12, 2023

Danke, hab ich vergessen xd

No bloody idea how I missed that file lol.
Installation might work fine if removed from PKGBUILD but it may be needed so regular user applications can access the cam. We should add that one just to be safe. Submitted the PR #23

@sigboe
Copy link
Contributor

sigboe commented Jun 12, 2023

Haha I also missed the 70-ipu6-psys.rules when reading this PR. I had the same issue when I first did testing locally, so I should have caught it

@stefanpartheym
Copy link
Owner

Danke, hab ich vergessen xd

No bloody idea how I missed that file lol. Installation might work fine if removed from PKGBUILD but it may be needed so regular user applications can access the cam. We should add that one just to be safe. Submitted the PR #23

Haha, don't worry. Maybe the .gitignore was preventing the file to be shown in git status ;)

@petobens
Copy link

@elhossary I also have an X1 carbon with Arch and i tried with both 6.1.34-1-lts and 6.3.8 and cannot get the camera to work. Running systemctl status v4l2-relayd.service shows:

Jun 18 19:20:30 X1-Carbon systemd[1]: Starting v4l2-relay daemon service...
Jun 18 19:20:30 X1-Carbon systemd[1]: Started v4l2-relay daemon service.
Jun 18 19:20:30 X1-Carbon v4l2-relayd[45191]: gst_element_set_state: assertion 'GST_IS_ELEMENT (element)' failed

and bash test.sh:

(gst-launch-1.0:46779): GStreamer-CRITICAL **: 19:20:41.082: gst_element_link_pads_filtered: assertion 'GST_IS_BIN (parent)' failed
ERROR: pipeline could not be constructed: syntax error.

FWIW I'm using Xorg.. any ideas?

@stefanpartheym @striczkof any pointers are also greatly appreciated..

@Devidxyz
Copy link

I got an error on Dell XPS 13 Plus 9320 running Arch Linux kernel 6.5.3-arch1-1

configure: error:
      You need to install or upgrade the GStreamer development
      packages on your system. On debian-based systems these are
      libgstreamer1.0-dev; on RPM-based systems gstreamer1.0-devel.
      The minimum version required is 1.0.0.

==> ERROR: A failure occurred in build().
    Aborting...
ERROR: Failed to build/install: v4l2-relayd

The gstreamer package wasn't enough, I had to manually install gst-libav too (in case anyone gets the same error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation of icamerasrc-git fails
6 participants