Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cmake to makedepends on intel-ipu6ep-camera-hal-git PKGBUILD #25

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Rend0e
Copy link
Contributor

@Rend0e Rend0e commented Jun 13, 2023

Referencing (https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=intel-ipu6ep-camera-hal-git), cmake is missing in makedepends.

Fixes "ERROR: Failed to install: intel-ipu6ep-camera-hal-git"
/home/redacted/Downloads/archlinux-ipu6-webcam/intel-ipu6ep-camera-hal-git/PKGBUILD: line 23: cmake: command not found

Referencing (https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=intel-ipu6ep-camera-hal-git), cmake is missing in makedepends.

Fixes "ERROR: Failed to install: intel-ipu6ep-camera-hal-git"
/home/redacted/Downloads/archlinux-ipu6-webcam/intel-ipu6ep-camera-hal-git/PKGBUILD: line 23: cmake: command not found
@alvinpeters
Copy link
Contributor

alvinpeters commented Jun 14, 2023

LGTM

Just remove 70-ipu6-psys.rules since gitignore drops that file. My commit at f91e6eb changes the PKGBUILD of icamerasrc-git-fix to print it in the packaging. That makes it a bit easier to maintain.

@Rend0e
Copy link
Contributor Author

Rend0e commented Jun 14, 2023

Removed 70-ipu6-psys.rules. Oops, added that file to fix the not found error but forgot that it would be included in this pull request.

@alvinpeters
Copy link
Contributor

alvinpeters commented Jun 14, 2023

Awesome thanks

I actually included that in my original PR #22 but forgot about the gitignore not adding anything inside the folders except PKGBUILD lol

@sigboe
Copy link
Contributor

sigboe commented Jun 14, 2023

LGTM 👍

But but would be nice if you squashed these commits into one commit

@stefanpartheym stefanpartheym merged commit 8f2b062 into stefanpartheym:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants