Keep --output-path up to date from build and serve commands. #1034
Conversation
|
I've been in the position lately to be running around 5-10 interdependent apps, and it would be VERY nice to be able to link them instead of adding an @stefanpenner - Pending your review + testing, but I'd like to see this in the next release if it passes muster. |
|
ya, link is wonderful :) Especially thanks to @krisselden's broccoli-sane-watcher which reduced idle CPU, next big win will by restoring broccoli's perfs |
| var promises = []; | ||
| var entries = fs.readdirSync(this.outputPath); | ||
|
|
||
| for (var i = 0, l = entries.length, path = entries[i]; i < l; i++) { |
There was a problem hiding this comment.
leave a quick comment, why we don't just rimraf the whole dir. (e.g. symlinks)
There was a problem hiding this comment.
Wrote a function comment explaining what was going on here.
|
left one comment, otherwise LGTM |
* Adds ability to specify output-path for `ember server` command. * Removes usage of `broccoli-export-tree` in favor of maintaining a single set of logic in the `Builder` model. (previously we had logic in both the `Build` task and `loadBrocfile` utility function to keep the output directory in sync)
Keep --output-path up to date from build and serve commands.
|
:) |
|
Eh.. awesome! Does this fix this problem then? #16 so now it's going to be quite easy to use ember server with node-webkit |
|
@mansona yup! |
ember servercommand.broccoli-export-treein favor of maintaining a single set of logic in theBuildermodel. (previously we had logic in both theBuildtask andloadBrocfileutility function to keep the output directory in sync).Closes #1031.