[fixes #1083] ensure the CLI exits with the correct status #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You make it look too simple. Thank you for cleaning up my mess 😄 |
|
other commands no longer "hold' until complete, like server. These will need to be refactored to support this. This was the original architecture, we may have lost it but we can restore it |
|
i added a fix for serve, can you review? |
|
LGTM, can you confirm the |
|
@rjackson ya, |
| environment: 'development', | ||
| outputPath: outputPath | ||
| }) | ||
| environment: 'development', |
There was a problem hiding this comment.
Is the 4-space indent intentional?
There was a problem hiding this comment.
stefanpenner
added a commit
that referenced
this pull request
Jun 25, 2014
[fixes #1083] ensure the CLI exist with the correct status
stefanpenner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.