Allow vendor files to be easily configurable. #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjackson this is much better. |
|
lets wait till we have the config object, i am nervous adding new features now that will change shortly. |
|
@stefanpenner - Generally understood and agreed, but even with the config stuff I think the internal structure will be similar to the |
|
@rjackson alright :) |
|
no longer merges |
This allows alternate paths to be specified, or completely removed.
For example to exclude jQuery from the generated `vendor.js` file:
```javascript
var app = new EmberApp({
vendorFiles: {
'jquery.js': null
}
});
```
This is a precursor to the new configuration syntax that will could
something like `app.config('vendorFiles', 'ember.js', <options here>)`.
|
Rebased. |
rwjblue
added a commit
that referenced
this pull request
Jul 4, 2014
Allow vendor files to be easily configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows alternate paths to be specified, or completely removed.
For example to exclude jQuery from the generated
vendor.jsfile:This is a precursor to the new configuration syntax that will could something like
app.config('vendorFiles', 'ember.js', <options here>).Closes #1182.
/cc @kiwiupover