Add verbose option to version command #1307
Conversation
|
Lookin' good! I'd like to see Can you add a changelog entry and some tests? |
|
|
||
| versions['npm'] = require('npm').version; | ||
|
|
||
| for (module in versions) { |
There was a problem hiding this comment.
Should be for (var module in versions) { (otherwise you are making a global variable and JSHint is not happy).
|
ChangeLog entry no problem. Tests I'm not really sure what and how to test this thus I was asking :-) |
|
Of course I can squash the commits once the PR is ready |
|
Mind adding a quick test? |
|
I tried adding a test for this but I'm not sure I'm doing it right. Here's my effort: gavacho@6125691 |
|
Looking reasonable to me. Pulling it into my fork, so it shows up here and can be discussed 👍 |
|
Seems good. Can you squash into two commits (one for each author)? |
| versions['npm'] = require('npm').version; | ||
|
|
||
| for(var module in versions) { | ||
| switch(module) { |
There was a problem hiding this comment.
Might be able to remove this switch in favor of something like https://gist.github.com/rjackson/df7c8f0a2b74ee668778.
|
Will need another rebase (changelog has a conflict from a recent PR merged). |
|
Looks like JSHint is not happy with the indentation of one of the |
Add verbose option to version command
Let me know if you want a test and how you would imagine the implementation.