-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmberAddon #1343
EmberAddon #1343
Conversation
These defaults look great, but maybe we should just have a second file (that itself just uses and returns an Then the var EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
var addon = EmberAddon();
module.exports = addon.toTree(); And internally it would just require |
that could also work, this PR is just a placeholder for now as I think once I get the addon discovery stuff working we discussed last night in IRC it will simplify this quite a bit. |
@rjackson this is a much cleaner implementation than the |
I will follow up with another PR that can discover other addons outside of |
Looks like there are a few JSHint errors. Travis still can't run with 0.10.26 (unrelated to this PR). |
fixed |
needs a rebase |
Will call the EmberApp constructor with defaults for addon projects. In the addons Brocfile only the following is required: ```js var EmberAddon = require('ember-cli/lib/broccoli/ember-addon'); var addon = new EmberAddon(); module.exports = addon.toTree(); ```
rebased |
failing test is just that broken node version. merging. |
In my addon, I have two separate vendor imports depending on whether the environment is development or production. Is that still possible using this new addon configuration format? |
@dustinfarris yes, you will just handle that conditional in the addonTreesFor function. Also, there will be some movement coming this week on the "way" to do this. |
Cool. Thanks for putting this together. |
@bcardarella giving a talk at EmberATX tomorrow night. Any chance I could get a small snippet or a link to a post with more detail on how it will be done in the future? |
@jfelchner I don't know where things will eventually land but this is a proposal I have written up: https://gist.github.com/bcardarella/cbf4049484159e6082af however that has not been tested in "real-world" yet. |
@jfelchner that being said, it might be premature to present on this stuff. Could do more harm than good if people think this is what the final API will actually be |
@bcardarella thanks for the quick reply. I have a section for "Here There Be Dragons". They will be duly warned. 😄 |
@jfelchner 👍 if that's the first slide. and every other slide after that, haha |
@jakecraige I took a screen grab of this convo and put it in my talk. I also decided, after your comment to make it dragon themed and added this as the title slide. Thanks for the inspiration! 😄 |
@jfelchner nice! |
Will call the EmberApp constructor with defaults for addon projects. In
the addons Brocfile only the following is required: