Allow addons to be vendored outside of node modules #1370
Conversation
|
|
||
| addonPkg['ember-addon'] = addonPkg['ember-addon'] || {}; | ||
| Project.prototype.determineIfAddon = function(addonPath, addonPackages) { |
There was a problem hiding this comment.
This method name is confusing to me. It seems like it returns a boolean but it actually changes addonPackages. Something like addToPackagesIfAddon is easier to read. I'm sure someone could come up with a better name that what I did though, lol
There was a problem hiding this comment.
yeah I agree the name sucks, it was late and I couldn't think of anything better. Suggestions welcome! 😄
|
@bcardarella looks good to me |
|
i can extrapolate some reasons for this, such as a app specific addon that has no purpose being part of NPM. Is this the use-case you invision ? |
|
Correct, but also for adding the addon through the normal addon On Sunday, July 13, 2014, Stefan Penner notifications@github.com wrote:
Brian Cardarella |
| return addonPackages; | ||
| }; | ||
|
|
||
| Project.prototype.determineIfAddon = function(addonPath, addonPackages) { |
There was a problem hiding this comment.
Can you tweak this to addIfAddon?
In package.json you can add paths for additional addons
```json
"ember-addon": {
"paths": [
"./lib/super-button"
]
}
```
The vendored library must conform to the addon spec, so it must have a
properly declared `package.json` file as well as its own loader.
Allow addons to be vendored outside of node modules
In package.json you can add paths for additional addons
The vendored library must conform to the addon spec, so it must have a
properly declared
package.jsonfile as well as its own loader.