Pull server files from http-{mock,proxy} into their own blueprint

[jgwhite]

Fixes #2356

[stefanpenner]

thank you sir!

[indirect]

This seems to have caused conflicting blueprints for server/index.js. In 0.1.4, if I run ember g server, I get a file that uses morgan, tries to include proxies, but doesn't use connect-restreamer. If I run ember g http-proxy, I get a server index file that doesn't use morgan, does use connect-restreamer, and also includes proxies. Shouldn't the http-proxy generator just use the server generator?

[rwjblue]

@indirect - Yes, I believe that it should. Can you open an issue (or PR)?

[jgwhite]

@indirect that's odd because that's exactly what the http-proxy blueprint does:

https://github.com/stefanpenner/ember-cli/blob/master/blueprints/http-proxy/index.js#L26

I'll check to see what I missed.

[indirect]

I can try to get you a diff tomorrow, if that would help. The changes I noticed were whether morgan was included in server/index.js, and whether connect-restreamer was used before the proxies were used.

On Dec 8, 2014, at 9:32 PM, Jamie White notifications@github.com wrote:

@indirect https://github.com/indirect that's odd because that's exactly what the http-proxy blueprint does:

https://github.com/stefanpenner/ember-cli/blob/master/blueprints/http-proxy/index.js#L26 https://github.com/stefanpenner/ember-cli/blob/master/blueprints/http-proxy/index.js#L26
I'll check to see what I missed.

—
Reply to this email directly or view it on GitHub #2610 (comment).

[jgwhite]

@indirect connect-restreamer was dropped around the time of #2568. The fact you’re seeing it when running ember g http-proxy ... suggests an older version of the http-proxy blueprint is being used. Could you post the contents of node_modules/ember-cli/blueprints/http-proxy/index.js in your project?

[rwjblue]

@indirect - Are you using the built-in generators or overridden generators from another addon (like ember-cli-coffeescript)?

[indirect]

Ohhhhh, wow, I feel dumb. After checking, yes, I have an overwritten generator for http-proxy and no overwritten generator for server. Thanks, and sorry about that!

[stefanpenner]

@indirect no problem, this project moves fast. Hopefully we can figure out a way of messaging these issues.

Maybe some improved debug logging in this area?

[jgwhite]

@stefanpenner @indirect improved logging definitely. Console output along this lines of:

Installing this-cool-project/http-proxy...

would it make it much clearer what’s afoot here.