Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ember/load-initializer vendor'd package #337

Merged
merged 1 commit into from
Apr 11, 2014

Conversation

ghedamat
Copy link
Contributor

As per discussion on stefanpenner/ember-app-kit#588 use https://github.com/stefanpenner/ember-load-initializers also in ember-cli

I'm kinda new to ember-cli so let me know if this is ok or if there is some path to test this kind of changes to the blueprint (that is not try the generated app)

thanks

/cc @stefanpenner

@ghedamat ghedamat changed the title use load-initializer vendor'd package use ember/load-initializer vendor'd package Apr 11, 2014
stefanpenner added a commit that referenced this pull request Apr 11, 2014
use ember/load-initializer vendor'd package
@stefanpenner stefanpenner merged commit 0c9720a into ember-cli:master Apr 11, 2014
@ghedamat ghedamat deleted the mattia/test-initializers branch April 11, 2014 21:29
@twokul
Copy link
Contributor

twokul commented Apr 12, 2014

@ghedamat thanks for the PR! Because ember-cli is on early stages, it is required to change CHANGELOG.md for every PR. mind doing that?

@stefanpenner please DO NOT merge PRs w/o new CHANGELOG entries

@fsmanuel
Copy link
Contributor

i pushed a 0.0.1 tag so we can lock in bower.json

"ember-load-initializers": "git://github.com/stefanpenner/ember-load-initializers.git#0.0.1"

@rwjblue
Copy link
Member

rwjblue commented Apr 12, 2014

👍 to locking things down as much as possible.

On Apr 12, 2014, at 9:50 AM, Manuel Wiedenmann notifications@github.com wrote:

i pushed a 0.0.1 tag so we can lock in bower.json

"ember-load-initializers": "git://github.com/stefanpenner/ember-load-initializers.git#0.0.1"

Reply to this email directly or view it on GitHub.

@stefanpenner
Copy link
Contributor

@ghedamat oops, can you follow up with a changelog entry?

@fsmanuel
Copy link
Contributor

@ghedamat i'll add the changelog entry and lock it to 0.0.1

fsmanuel added a commit to fsmanuel/ember-cli that referenced this pull request Apr 12, 2014
stefanpenner added a commit that referenced this pull request Apr 12, 2014
updates changelog to reflect #337
@ghedamat
Copy link
Contributor Author

Sorry guys! I'm about to get home soon. Can tackle the changelog shortly if
you haven't already.

Sorry again for missing that!
On 12 Apr 2014 11:09, "Manuel Wiedenmann" notifications@github.com wrote:

@ghedamat https://github.com/ghedamat i'll add the changelog entry and
lock it to 0.0.1

Reply to this email directly or view it on GitHubhttps://github.com//pull/337#issuecomment-40282729
.

@twokul
Copy link
Contributor

twokul commented Apr 12, 2014

@ghedamat no worries, it was added.

@ghedamat
Copy link
Contributor Author

thanks @fsmanuel !

@twokul I completely missed the changelog requirement, will keep it in mind for next time :)

thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants