Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new tmp/output location for Testem. #463

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 27, 2014

This allows using the command line version of testem in addition to running
in CI mode (the current behavior).

@twokul
Copy link
Contributor

twokul commented Apr 27, 2014

LGTM, @abuiles can you +1/-1?

@rwjblue
Copy link
Member Author

rwjblue commented Apr 27, 2014

There is an issue with auto-reloading when using the command line version of Testem (via testem). I'm working on it now....

@@ -25,6 +26,9 @@ module.exports = new Command({
return build.run({ environment: 'development', outputPath: cwd })
.then(function() {
return test.run(testOptions);
})
.finally(function() {
quickTemp.remove(bind, '-testsDist');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abuiles
Copy link
Member

abuiles commented Apr 27, 2014

@rjackson thanks! let me know if you need any help with the auto-reloading issue.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 27, 2014

It does not appear that testem itself is restarting tests properly when files change. I created a super simple static file test repo at https://github.com/rjackson/testem-reload-failure which demonstrates the problem fairly well. I have also commented on an open issue in the Testem repo here: testem/testem#314 (comment)

So the issue is not with my changes here (they at least allow testem to work properly from the command line), and I think this is mergeable as is. I will continue to work with the Testem folks to try and track down why this fails.

@stefanpenner
Copy link
Contributor

can you add a changelog entry?

This allows using the command line version of `testem` in addition to
running in CI mode (the current behavior).
@rwjblue
Copy link
Member Author

rwjblue commented Apr 27, 2014

@stefanpenner - CHANGELOG.md entry added.

stefanpenner added a commit that referenced this pull request Apr 27, 2014
Use new `tmp/output` location for Testem.
@stefanpenner stefanpenner merged commit db82f31 into ember-cli:master Apr 27, 2014
@rwjblue rwjblue deleted the use-testem-json-for-testem-cwd branch April 27, 2014 14:40
@rwjblue
Copy link
Member Author

rwjblue commented Apr 27, 2014

Next step is to make ember test --server work properly. I believe once I add that we will be able to get the reloads/restarts properly from Testem, as we will just trigger their programmatic API directly.

Working on PR now.

@stefanpenner
Copy link
Contributor

test:server

@stefanpenner
Copy link
Contributor

or we can do --server

@rwjblue
Copy link
Member Author

rwjblue commented Apr 27, 2014

I'm just cleaning up a few failing tests, but i have test --server working now. Happy to change either way...

@stefanpenner
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants