New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new tmp/output
location for Testem.
#463
Use new tmp/output
location for Testem.
#463
Conversation
LGTM, @abuiles can you +1/-1? |
There is an issue with auto-reloading when using the command line version of Testem (via |
@@ -25,6 +26,9 @@ module.exports = new Command({ | |||
return build.run({ environment: 'development', outputPath: cwd }) | |||
.then(function() { | |||
return test.run(testOptions); | |||
}) | |||
.finally(function() { | |||
quickTemp.remove(bind, '-testsDist'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@rjackson thanks! let me know if you need any help with the auto-reloading issue. |
It does not appear that testem itself is restarting tests properly when files change. I created a super simple static file test repo at https://github.com/rjackson/testem-reload-failure which demonstrates the problem fairly well. I have also commented on an open issue in the Testem repo here: testem/testem#314 (comment) So the issue is not with my changes here (they at least allow |
can you add a changelog entry? |
This allows using the command line version of `testem` in addition to running in CI mode (the current behavior).
@stefanpenner - CHANGELOG.md entry added. |
Use new `tmp/output` location for Testem.
Next step is to make Working on PR now. |
|
or we can do |
I'm just cleaning up a few failing tests, but i have |
👍 |
This allows using the command line version of
testem
in addition to runningin CI mode (the current behavior).