Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print build times for ember server. #865

Merged
merged 1 commit into from
May 30, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 30, 2014

With the slow trees being printed automatically, we need some separation between slow-tree tables. It is also nice to see the total time to put everything in the proper perspective.

Before

before

After

after

@stefanpenner
Copy link
Contributor

LGTM

With the slow trees being printed automatically, we need some separation
between slow-tree tables. It is also nice to see the total time to put
everything in the proper perspective.
stefanpenner added a commit that referenced this pull request May 30, 2014
Print build times for `ember server`.
@stefanpenner stefanpenner merged commit ad362b1 into ember-cli:master May 30, 2014
@stefanpenner stefanpenner deleted the print-rebuild-times branch May 30, 2014 04:30
@stefanpenner
Copy link
Contributor

@rjackson seems like we need to do a 2 pass walk of that data. 1 to gather max lengths, and 1 to pad accordingly.

@stefanpenner
Copy link
Contributor

but now that we have some improved visibility, we should work to reduce the costs.

@rwjblue
Copy link
Member Author

rwjblue commented May 30, 2014

Confirm. I'll work up a PR to broccoli (to make the alignment better).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants