Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Lambda Function #1

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Conversation

aarondfrancis
Copy link
Collaborator

Ok I think I got it all working. Saving files and everything. I basically just ended up overwriting the callBrowser part and had to do a bit of mucking around with files, but beyond that we're able to still use all of Spatie's stuff! Lemme know what you think!

Copy link
Owner

@stefanzweifel stefanzweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so awesome Aaron. Thank you! ❤️

src/Functions/BrowsershotFunction.php Outdated Show resolved Hide resolved
src/Functions/BrowsershotFunction.php Show resolved Hide resolved
@stefanzweifel stefanzweifel changed the title Working Refactor Lambda Function Feb 5, 2022
@stefanzweifel stefanzweifel merged commit 348f10a into stefanzweifel:main Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants