Skip to content
This repository has been archived by the owner on May 10, 2020. It is now read-only.

trivial: make StmtStream Send #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agalakhov
Copy link
Contributor

StmtStream was not Send due to pointer in PhantomData. This pointer makes no sense since PhantomData is already zero-sized.

This is likely to fix #103.

Signed-off-by: Alexey Galakhov agalakhov@snapview.de

Signed-off-by: Alexey Galakhov <agalakhov@snapview.de>
@steffengy
Copy link
Owner

Technically this is related to dropchk, which is why a &'static R would be more appropriate.

I'm at this time not planning to cut another 0.3 release,
since I'd like to get a preview of 0.4 (async/await) ready in a few weeks,
with the goal of addressing most painpoints.

@agalakhov
Copy link
Contributor Author

Unfortunately &'static R won't work since it is not Send if R is not Sync. Only non-pointer type will do.
Another possible solution would be unsafe impl Send.

@steffengy
Copy link
Owner

steffengy commented Oct 18, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send BoxableIo safely between threads
2 participants