Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and a new feature #45

Merged
merged 3 commits into from
Mar 21, 2013
Merged

Bugfixes and a new feature #45

merged 3 commits into from
Mar 21, 2013

Conversation

jlnquere
Copy link
Contributor

Hi,

Here is 3 commits that I've made for my project needs:

  • 1 Bugfix about the container view height. To understand the bug, simply do this in the PSStackedViewExample AppDelegate, and launch the App in horizontal orientation:
    // set root controller as stack controller
    ExampleMenuRootController *menuController = [[ExampleMenuRootController alloc] init];
    self.stackController = [[PSStackedViewController alloc] initWithRootViewController:menuController];

    ExampleViewController1 * vc = [[ExampleViewController1 alloc] init];
    [[self stackController] pushViewController:vc animated:NO];
  • 1 bugfix about ContainerView transparentView frame.
  • 1 new feature that allow overlapped VC to come back to front within a tap (like the old Twitter way).

J.

Adding enablePopOverlapedViewOnTap to PSStackedViewController.

When true, overlaped views (with overlap ratio under
kPSSVOverlapMinimalValueToApplyDarkRatio) do not accept touches from
user. But, when view is tapped (via UITapGestureRecognizer), the stack
is poped to this viewController.
Sometimes, PSStackedViewController do not set the good height to a
pushed viewController … Fixed.
Sometimes, PSSVContainerView transparentView frame is not right (it do
not take the full ContainerView bounds). Fixed.
@steipete
Copy link
Owner

Looks all good - thanks!

steipete added a commit that referenced this pull request Mar 21, 2013
Bugfixes and a new feature
@steipete steipete merged commit fb9bf4f into steipete:master Mar 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants