Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple laps #9

Merged
merged 4 commits into from
Jul 21, 2018
Merged

Multiple laps #9

merged 4 commits into from
Jul 21, 2018

Conversation

stela
Copy link
Owner

@stela stela commented Jul 18, 2018

Handle waypoints wraparound and override any zero speed waypoint provided.

@stela
Copy link
Owner Author

stela commented Jul 18, 2018

Intended to resolve #7.

@stela stela requested a review from StefanGerlach July 18, 2018 15:07
@StefanGerlach
Copy link
Collaborator

Works well!

@StefanGerlach StefanGerlach merged commit 0706fb3 into master Jul 21, 2018
@stela stela deleted the multiple-laps branch July 21, 2018 14:45
@stela
Copy link
Owner Author

stela commented Aug 8, 2018

We should probably reverse part of this change if we need to re-submit, apparently the car is supposed to respect the 0 waypoint speeds, see https://carnd.slack.com/archives/C6NVDVAQ3/p1522261806000786

Stephen Welch
Hi All! The vehicle should follow the speed set for each waypoint (in this case coming to a stop at the end of the waypoints). We don't expect the vehicle to be able to continuously drive in a loop. However, we may try to restart the dbw in the middle of the waypoint set after driving the loop once, if needed. (e.g. if we want to get another shot at the traffic light.)

From a thread in #s-t3-p-system-integra, Mar 28th at 20:30

The wraparound-support though seems useful, should keep that part, just remove the waypoint speed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants