Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method getMatchList from Valorant api not being deserialized properly #32

Closed
mohasaid opened this issue Mar 10, 2022 · 0 comments
Closed

Comments

@mohasaid
Copy link
Contributor

Problem

I'm using the latest version 2.1.4.

Currently, the method getMatchList from VALMatchAPI is returning a List<MatchReference>, and all entries in the list are not deserialized properly. The entity MatchReference has the following attributes:

public class MatchReference implements Serializable
{    
    private String matchId;
    private Long   gameStartTime;
    private String teamId;
   ....
}

But the Valorant API from Riot returns the following attributes:

{
    "matchId": "20ae16ff-45d3-1234-b7bd-6d185fd77ba3",
    "gameStartTimeMillis": 1646476634080,
    "queueId": "competitive"
}

Solution

Rename the attributes of the MatchReference entity to the following ones:

public class MatchReference implements Serializable
{    
    private String matchId;
    private Long   gameStartTimeMillis;
    private String queueId;
   ....
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants