Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summoner Endpoints get cached for a year #55

Closed
NichtFilip opened this issue Jan 5, 2023 · 1 comment
Closed

Summoner Endpoints get cached for a year #55

NichtFilip opened this issue Jan 5, 2023 · 1 comment

Comments

@NichtFilip
Copy link

The Endpoints V4_SUMMONER_BY_NAME, V4_SUMMONER_BY_PUUID, V4_SUMMONER_BY_ACCOUNT, V4_SUMMONER_BY_ID get cached for a year by default. I think that's a bit too long as player level and profile icon will realistically never update.
@stelar7
Copy link
Owner

stelar7 commented Jan 5, 2023

You have the option of overriding the default duration. So a year base is fine imo. #wontfix

@stelar7 stelar7 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stelar7 @NichtFilip