Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

kelp bot process crash error while running with fill tracker (add support for path_payment type operations) #219

Closed
nikhilsaraf opened this issue Aug 5, 2019 · 1 comment · Fixed by #251
Assignees
Labels
bug Something isn't working Kelpathon SDF Internal Kelpathon
Projects
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

2019/08/05 23:28:26 not deleting any offers, fillTrackerDeleteCycles (=40) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:26 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:27 not deleting any offers, fillTrackerDeleteCycles (=41) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:27 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:28 not deleting any offers, fillTrackerDeleteCycles (=42) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:28 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:29 not deleting any offers, fillTrackerDeleteCycles (=43) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:29 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:30 not deleting any offers, fillTrackerDeleteCycles (=44) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:30 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:31 not deleting any offers, fillTrackerDeleteCycles (=45) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:31 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:32 not deleting any offers, fillTrackerDeleteCycles (=46) needs to exceed fillTrackerDeleteCyclesThreshold (=50)
2019/08/05 23:28:32 error when fetching trades: error converting tradesPage2TradesResult: could not load orderAction: could not cast 'selling_asset_type' to a string in the operation json result: %!s() (type=)
2019/08/05 23:28:32 (async) tx confirmation hash: 1dcd442a81cf8049871bdada91af08a7a4b9a4e4fe3ac33bd3969e0c92463d01

@nikhilsaraf nikhilsaraf added bug Something isn't working Kelpathon SDF Internal Kelpathon labels Aug 5, 2019
@nikhilsaraf nikhilsaraf self-assigned this Aug 18, 2019
@nikhilsaraf
Copy link
Contributor Author

nikhilsaraf commented Aug 18, 2019

this is caused by path payments, see the following:
manage offer trade which works
corresponding manage offer operation which works
corresponding effects for manage offer operation which is currently unused

trade from a path payment which doesn't work yet
corresponding operation from the path payment trade which doesn't work yet
corresponding effects from the path payment which doesn't work yet

the operation from the path payment does not have a selling_asset_type but has a path field and source_* fields which we need to check. this can be hinged on the type of the operation which is either path_payment or manage_offer.

need to update sdex.go#getOrderAction. Can go to the effects directly to check for the trade type of effect so it is standardized across both manage_offer and path_payment type of operations.

nikhilsaraf added a commit that referenced this issue Aug 19, 2019
…dex, fixes #219

* 1 - use effects to getOrderAction so it works with both types of operations: manage_offer and path_payment
@nikhilsaraf nikhilsaraf added this to Triage in Kelp via automation Aug 19, 2019
@nikhilsaraf nikhilsaraf added this to the v1.7.2 milestone Aug 19, 2019
nikhilsaraf added a commit that referenced this issue Aug 26, 2019
…dex, fixes #219

* 1 - use effects to getOrderAction so it works with both types of operations: manage_offer and path_payment
@nikhilsaraf nikhilsaraf moved this from Triage to Done in Kelp Sep 4, 2019
@nikhilsaraf nikhilsaraf changed the title kelp bot process crash error while running with fill tracker kelp bot process crash error while running with fill tracker (add support for path_payment type operations) Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Kelpathon SDF Internal Kelpathon
Projects
Kelp
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant