Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Travis build should run existing tests #57

Closed
nikhilsaraf opened this issue Nov 17, 2018 · 0 comments
Closed

Travis build should run existing tests #57

nikhilsaraf opened this issue Nov 17, 2018 · 0 comments
Assignees
@nikhilsaraf
Labels
feature request New feature or request
Milestone
v1.2.0

Comments

@nikhilsaraf
Copy link
Contributor

Desired Behavior

I want to be able to run some basic tests in travis to avoid regressions during code merges

Impact

The desired behavior will allow me to be more confident about code changes and will encourage more testing around the code

Feature Suggestion

We can achieve the desired behavior by adding a line in the travis build that will run tests. Any tests that cannot be run in an automated manner (require API keys or HTTP access) can be set to a mode that will not run in the Travis build.

Additional context

related to #51
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Nov 17, 2018
@nikhilsaraf nikhilsaraf added this to the v1.2.0 milestone Nov 17, 2018
@nikhilsaraf nikhilsaraf self-assigned this Nov 17, 2018
nikhilsaraf added a commit to nikhilsaraf/kelp that referenced this issue Mar 5, 2020
@nikhilsaraf
Travis build runs existing tests, closes stellar-deprecated#57 (stell…
9e78cb2 
…ar-deprecated#58)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
feature request New feature or request
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@nikhilsaraf