Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[Nikhil ad-hoc] [5] (5) Simple Integration test for buysell strategy #51

Closed
nikhilsaraf opened this issue Nov 12, 2018 · 3 comments
Closed
Assignees
Labels
feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Nov 12, 2018

Desired Behavior

Travis test run should fail of the build is unable to start up and trade

Impact

The desired behavior will allow me to confidently merge pull requests without having to sync the code and test locally

Feature Suggestion

We can achieve the desired behavior by having a simple integration test that generates the required accounts, assets, and trustlines, funding, and runs a simple trading strategy.

This should be run as a go test along with all the other existing tests.

Testing against the test network is ok for now (vs. spinning up a new private testnet)

This can run against the buysell strategy

@nikhilsaraf nikhilsaraf self-assigned this Nov 12, 2018
@nikhilsaraf nikhilsaraf added the good first issue Good for newcomers label Nov 12, 2018
@nikhilsaraf nikhilsaraf added this to the v1.2.0 milestone Nov 12, 2018
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Nov 12, 2018
@nikhilsaraf nikhilsaraf modified the milestones: v1.2.0, v2.0.0 Nov 12, 2018
@nikhilsaraf nikhilsaraf added the help wanted Extra attention is needed label Jan 16, 2019
@nikhilsaraf nikhilsaraf removed their assignment Jan 17, 2019
@nikhilsaraf
Copy link
Contributor Author

use hardcoded accounts for now, if testnet is reset anytime we can always circle back to autogenerated accounts.

@nikhilsaraf
Copy link
Contributor Author

nikhilsaraf commented Jan 29, 2019

Can use testnet for now.

If it's easy and computationally inexpensive, can consider using docker quickstart in standalone mode for a "private" network. just start it with --standalone switch.

two options:

  • just start the container at the beginning of the tests, run your bootstrap code and do it every time or
  • start a container but cache it, so you don't have to run the bootstrap code each time.

second option may be actually slower because travis has some problem with caching large files. you need to check it out.

@nikhilsaraf nikhilsaraf added this to Backlog in Kelp Feb 6, 2019
@nikhilsaraf nikhilsaraf mentioned this issue Jun 3, 2020
2 tasks
@nikhilsaraf nikhilsaraf changed the title Simple integration test needed to confidently merge PR contributions [8] Simple integration test needed to confidently merge PR contributions Jun 3, 2020
@nikhilsaraf nikhilsaraf assigned debnil and unassigned Reidmcc Aug 18, 2020
@nikhilsaraf nikhilsaraf changed the title [8] Simple integration test needed to confidently merge PR contributions [3] Simple Integration test for buysell strategy Aug 18, 2020
@nikhilsaraf nikhilsaraf removed this from Backlog in Kelp Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [3] Simple Integration test for buysell strategy [5] Simple Integration test for buysell strategy Sep 20, 2020
@nikhilsaraf nikhilsaraf modified the milestones: later, v1.10.0 Sep 20, 2020
@nikhilsaraf nikhilsaraf modified the milestones: v1.10.0, v1.10.1 Oct 17, 2020
@nikhilsaraf
Copy link
Contributor Author

@debnil assigning to myself since I'm working on part of the code that touches this

@nikhilsaraf nikhilsaraf self-assigned this Oct 18, 2020
@nikhilsaraf nikhilsaraf changed the title [5] Simple Integration test for buysell strategy [5] (5) Simple Integration test for buysell strategy Oct 22, 2020
@nikhilsaraf nikhilsaraf changed the title [5] (5) Simple Integration test for buysell strategy [Nikhil ad-hoc] [5] (5) Simple Integration test for buysell strategy Oct 26, 2020
@debnil debnil removed their assignment Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants