This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Show balances #673
Merged
Show balances #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
STR shouldn't always be on top. Really we should sort them by $ value rather than nominal amount. But that can come later |
| 'account': session.get('address') | ||
| }); | ||
|
|
||
| accountLinesRequest.on('success', function(result) { |
There was a problem hiding this comment.
add deferred.reject for 'error'
There was a problem hiding this comment.
This didn't actually need to be a promise in the first place. Fixed.
|
I spoke with @jedmccaleb offline. Sorting by $ value is a little out of scope for this PR (and probably this branch). He is going to think more about this, but it doesn't block this PR. |
|
Pulled down and tested, looks good! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the account has balances in other currencies they are aggregated and displayed on the dashboard.
Currently the STR balance is always on top, then the two currencies with largest balances are shown in descending order. This will make more sense when the "all balances" button is added to provide access to the rest of the balances.
When a new transaction occurs the balances are updated.
This PR also contains a html/sass refactor suggested by @wynlim that groups the dashboard elements by column instead of by row. This cleaned up a lot of duplicate class names, and provides a more modular container structure that will allow the balance list to grow longer if needed.
Fixes #657.