Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions Module #274

Closed
Tracked by #276
jcx120 opened this issue May 24, 2022 · 17 comments
Closed
Tracked by #276

Transactions Module #274

jcx120 opened this issue May 24, 2022 · 17 comments

Comments

@jcx120
Copy link

jcx120 commented May 24, 2022

Build a "Transactions" container component with the following elements:

  1. Transactions Per Second (TPS): 120
  2. Historical TPS - last 30 days (Nice to have)
    • Graph chart of average daily TPS over past 30 days, MainNet only
  3. Recent Operations
    • See legacy Dashboard
    • Last 10
    • Fields: Source Operation | Details | Time ago

Considerations:

  • The "Transaction" container component will need to be created
  • Use Stellar Design System (SDS) components as much as possible.
  • Icons should also be used from the SDS ( component). It's OK if they differ slightly.
  • Backend data will vary depending on the data element
  • On Mainnet and TestNet
@jcx120 jcx120 mentioned this issue May 24, 2022
3 tasks
@raphaelmartins1993
Copy link

@jcx120
Where we can get these operations? Horizon or Hubble?
If Hubble, which tables?

@jcx120
Copy link
Author

jcx120 commented Jun 1, 2022

For
1+2) see the github link to see how they calculate it. There might also be something available in Hubble but will need to check
3) This is an existing module in the current Dashboard v1
The API: https://horizon.stellar.org/operations?order=desc&limit=10
(We can limit it to 10)

@raphaelmartins1993
Copy link

hello @jcx120, in the historical TPS of the transactions module we should always bring the last 30 days fixed, or should we also have the possibility of filters such as 1 hour, 1 day, 30 days?
thanks!

@jcx120
Copy link
Author

jcx120 commented Jun 10, 2022

@raphaelmartins1993 If this is easy to do, then let's have the 1hr, 1day, 30 day filter to keep it consistent with other metrics. Otherwise, let's keep it fixed at 30 days.

@lccoronel
Copy link

Hi @jcx120 and @quietbits, we just did the transactions component with "Transactions Per Second" and "Historical TPS", what do you think of the layout?

Screen Shot 2022-06-28 at 15 58 21

@jcx120
Copy link
Author

jcx120 commented Jun 30, 2022

I think it looks fine. We can have UX @cbshin-stellar
review it once a staging instance is available so it can be seen in context.

@lccoronel
Copy link

I think it looks fine. We can have UX @cbshin-stellar review it once a staging instance is available so it can be seen in context.

ok, we have a preview here: https://dashboard-pr293.prototypes.kube001.services.stellar-ops.com/?network=mainnet

@lccoronel
Copy link

@jcx120 and @quietbits, another thing, I noticed that the "RECENT OPERATIONS: LIVE NETWORK" table on dashboard v1 some data is treated that is not returning in the horizon API like:

  • operation name
  • operation shares_received
  • shares

like others fields.

code

Are these data retrieved at some point in an operation or can we disregard them?

@jcx120
Copy link
Author

jcx120 commented Jul 1, 2022

Cool! I'm assuming the Fees module and Ledger module are coming soon correct?

@lccoronel
Copy link

yes, we are intending to finish this in the next days

@charles-sdf
Copy link

UX and visuals look great! no feedback to add, it's pretty 1:1 with the design so I'm happy with how the staging looks currently

@charles-sdf
Copy link

For Recent Operations, we can limit the number of items displayed to 10 rows.

@lccoronel
Copy link

Hi @jcx120, we still need to check this account?

code

I was chatting with @quietbits and I had this doubt?

@acharb
Copy link
Contributor

acharb commented Jul 8, 2022

@lccoronel let's remove it, doesn't look critical to me

@jcx120
Copy link
Author

jcx120 commented Jul 26, 2022

@lccoronel For the "Transactions Per Second" Module, lets:

  1. Move the "Current TPS" box to be above the graph
  2. Change the "Transactions" label for the graph to be "Average Daily Transactions"

This is so the most important info is available at the top. thanks

@jcx120
Copy link
Author

jcx120 commented Jul 27, 2022

@lccoronel Looking good and thanks for the updates. One minor text change:
For the "Ledger Operations" module, please update the "Operations" text (next to the dot) to be "Total monthly operations"

@lccoronel
Copy link

#302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants