Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints needs to authenticate user with jwt #9

Closed
msfeldstein opened this issue Nov 22, 2019 · 3 comments
Closed

Endpoints needs to authenticate user with jwt #9

msfeldstein opened this issue Nov 22, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@msfeldstein
Copy link
Contributor

Version 0.9.2

Currently the jwt authentication helper validates the jwt as a valid jwt issued by the anchor, but doesn't actually check which user is authenticating. This means anyone can access anyone elses information, such as transaction history, just by authenticating as themself, or any other stellar address.

Endpoints such as /transactions should get the stellar account from the jwt, rather than doing non-standard things like adding an account query parameter to choose who's info to return. /transactions?account=<> is not compliant with the spec and should be removed, using the sub account from the jwt instead.

@msfeldstein msfeldstein added the bug Something isn't working label Nov 22, 2019
@JakeUrban JakeUrban self-assigned this Nov 25, 2019
@JakeUrban
Copy link
Contributor

Changes:

  • Removed account parameter for /transactions
  • Adjusted /transactions, /transaction, and /transaction/more_info endpoint to use sub field from JWT

@JakeUrban
Copy link
Contributor

Addressed in #13

@JakeUrban
Copy link
Contributor

This was addressed in 0.9.5. There are still endpoint that should have JWT validation, but we don't want to pass the JWT in the URL. This issue is tracked in #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants