Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow including the token after previously being authenticated #315

Merged
merged 5 commits into from Sep 24, 2020

Conversation

JakeUrban
Copy link
Contributor

resolves #299

This makes the interactive JWT used a one-time token. If included in the URL of an interactive webapp GET request after being authenticated in a prior GET request, the server should reject the token. This ensures only one window can be opened.

Copy link
Contributor

@acharb acharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeUrban JakeUrban merged commit c2da616 into stellar:master Sep 24, 2020
@JakeUrban JakeUrban deleted the ott-jwt branch September 24, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade JWT used for interactive session to OTT
2 participants