add is-sac-contract route #74
Conversation
|
Preview is available here: |
|
One thing I learned recently is that SAC addresses are deterministic so you can actually derive them without looking at the executable at all. Assuming you have the "name" field from the contract and the contract ID. |
|
Preview is available here: |
src/route/index.ts
Outdated
|
|
||
| reply.code(200).send({ isSacContract }); | ||
| } catch (error) { | ||
| reply.code(500).send("Unexpected Server Error"); |
There was a problem hiding this comment.
since isSacContractExecutable can throw for legitimate errors, I don't think we want a 500 in this catch block. For example if you pass it a contract ID for an expired contract and it can't fetch the entries, it will throw an ERROR.ENTRY_NOT_FOUND.CONTRACT_CODE error.
There was a problem hiding this comment.
Maybe it makes more sense not to throw in that helper?
|
Preview is available here: |
* adapt to new mercury schema, no more muxed or byAccountId fields * default to using sdk v12.1.0 on all networks (#87) * add is-sac-contract route (#74) (#86) * add is-sac-contract route * remove throw from isSacContract helper * default to using sdk v12.1.0 on all networks * update sdk-next and contract spec api --------- Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org>
No description provided.