[FEATURE] Integrity check runs in worker #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
| email: conf.mercuryIntegrityCheckEmail, | ||
| password: conf.mercuryIntegrityCheckPass, | ||
| }, | ||
| // the worker is not properly instantiated when running this app with ts-node |
There was a problem hiding this comment.
I haven't found a great way to get this to work with out dev server, I think for now the easiest thing to do is to build and run the app manually using the webpack build when we need to test/work on the integrity check. It's a little cumbersome but not sure how to make it easier yet. Thoughts? @piyalbasu
There was a problem hiding this comment.
Interesting - yeah, I don't have a great solution off the top of my head. Since we'll likely be making more changes to the endpoints rather than the integrity checks, maybe this friction is fine for now. If it becomes a problem, we could always come back to this
piyalbasu
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds worker module and moves integrity check to run in worker thread
Moves common helpers to helper files
Why
This will help keep the main thread clear for API usage while the integrity check runs in worker thread